fix(python): change Python namespace to aws_cdk
#13489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current Python namespace in v2 for the monopackage is `aws_cdk_lib`, which means people need to update a lot of imports their source code. `aws_cdk` is the namespace used by the v1 packages, which means people who have already written code against v1 have less updating to do. Unfortunately there will still be SOME updating, as some classes *used* to be in `aws_cdk.core` but are now in `aws_cdk` directly. Tested that the `aws_cdk_lib` package that vends `aws_cdk/__init__.py` can still be installed without problems alongside `aws_cdk.cx_api` which vends `aws_cdk/cx_api/__init__.py`, and others.
|
|
rix0rrr
added
pr-linter/exempt-readme
iliapolo
approved these changes
Mar 9, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
added a commit
that referenced
this pull request
Mar 9, 2021
Backported change from v2 branch: #13489.
njlynch
pushed a commit
that referenced
this pull request
Mar 22, 2021
The current Python namespace in v2 for the monopackage is `aws_cdk_lib`, which means people need to update a lot of imports their source code. `aws_cdk` is the namespace used by the v1 packages, which means people who have already written code against v1 have less updating to do. Unfortunately there will still be SOME updating, as some classes *used* to be in `aws_cdk.core` but are now in `aws_cdk` directly. Tested that the `aws_cdk_lib` package that vends `aws_cdk/__init__.py` can still be installed without problems alongside `aws_cdk.cx_api` which vends `aws_cdk/cx_api/__init__.py`, and others. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Python namespace in v2 for the monopackage is
aws_cdk_lib, whichmeans people need to update a lot of imports their source code.
aws_cdkis the namespace used by the v1 packages, which means people who havealready written code against v1 have less updating to do.
Unfortunately there will still be SOME updating, as some classes used to be in
aws_cdk.corebut are now inaws_cdkdirectly.Tested that the
aws_cdk_libpackage that vendsaws_cdk/__init__.pycanstill be installed without problems alongside
aws_cdk.cx_apiwhich vendsaws_cdk/cx_api/__init__.py, and others.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license